Continue refinements of AddSettingsPluginRepository#7132
Merged
Conversation
AddPluginRepositoryAddSettingsPluginRepository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Fixes the AddSettingsPluginRepository recipe to correctly handle pluginManagement block placement in Gradle settings files, and corrects invalid test examples introduced in Fix AddSettingsPluginRepository duplicate pluginManagement when not first statement #7105.
Insertion of new pluginManagement blocks now skips past any leading import statements before inserting at position 0
Removed Groovy DSL tests that placed rootProject.name before pluginManagement (invalid in Groovy — "The pluginManagement {} block must appear before any other statements in the script")
Retained Kotlin DSL "not first statement" tests with rootProject.name before pluginManagement (valid in Kotlin DSL)
Added noPluginManagementBlockWithBuildCacheKts test covering the customer-reported scenario where buildCache exists and pluginManagement must be inserted before it
What's your motivation?
Verified with Gradle 9.3.1:
Checklist